]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/amdgpu: prevent NULL pointer dereference if ATIF is not supported
authorAntonio Quartulli <antonio@mandelbit.com>
Thu, 31 Oct 2024 15:28:48 +0000 (16:28 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 4 Nov 2024 17:05:16 +0000 (12:05 -0500)
commit91c9e221fe2553edf2db71627d8453f083de87a1
tree93508120eea4785da470248d86c263b90c2335a0
parent69516fbdba6c809c70a2c8c633c3a34361e9d3f0
drm/amdgpu: prevent NULL pointer dereference if ATIF is not supported

acpi_evaluate_object() may return AE_NOT_FOUND (failure), which
would result in dereferencing buffer.pointer (obj) while being NULL.

Although this case may be unrealistic for the current code, it is
still better to protect against possible bugs.

Bail out also when status is AE_NOT_FOUND.

This fixes 1 FORWARD_NULL issue reported by Coverity
Report: CID 1600951:  Null pointer dereferences  (FORWARD_NULL)

Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Fixes: c9b7c809b89f ("drm/amd: Guard against bad data for ATIF ACPI method")
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20241031152848.4716-1-antonio@mandelbit.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c