]> www.infradead.org Git - users/jedix/linux-maple.git/commit
selftests: mptcp: fix wait_rm_addr/sf parameters
authorGeliang Tang <geliang.tang@suse.com>
Wed, 25 Oct 2023 23:37:03 +0000 (16:37 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 27 Oct 2023 15:47:07 +0000 (08:47 -0700)
commit9168ea02b898d3dde98b51e4bd3fb082bd438dab
tree8536de32b15f5adf5ea5354fa739fa63686614fd
parentf4a75e9d11001481dca005541b6dc861e1472f03
selftests: mptcp: fix wait_rm_addr/sf parameters

The second input parameter of 'wait_rm_addr/sf $1 1' is misused. If it's
1, wait_rm_addr/sf will never break, and will loop ten times, then
'wait_rm_addr/sf' equals to 'sleep 1'. This delay time is too long,
which can sometimes make the tests fail.

A better way to use wait_rm_addr/sf is to use rm_addr/sf_count to obtain
the current value, and then pass into wait_rm_addr/sf.

Fixes: 4369c198e599 ("selftests: mptcp: test userspace pm out of transfer")
Cc: stable@vger.kernel.org
Suggested-by: Matthieu Baerts <matttbe@kernel.org>
Reviewed-by: Matthieu Baerts <matttbe@kernel.org>
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
Signed-off-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231025-send-net-next-20231025-v1-2-db8f25f798eb@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh