]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86: think-lmi: Fix kobject cleanup
authorKurt Borja <kuurtb@gmail.com>
Mon, 30 Jun 2025 17:31:20 +0000 (14:31 -0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 2 Jul 2025 09:01:23 +0000 (12:01 +0300)
commit9110056fe10b0519529bdbbac37311a5037ea0c2
tree9baa77ce4d92498b32df5addf16f8aaeaed38063
parent8dab34ca77293b409c3223636dde915a22656748
platform/x86: think-lmi: Fix kobject cleanup

In tlmi_analyze(), allocated structs with an embedded kobject are freed
in error paths after the they were already initialized.

Fix this by first by avoiding the initialization of kobjects in
tlmi_analyze() and then by correctly cleaning them up in
tlmi_release_attr() using their kset's kobject list.

Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
Fixes: 30e78435d3bf ("platform/x86: think-lmi: Split kobject_init() and kobject_add() calls")
Cc: stable@vger.kernel.org
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250630-lmi-fix-v3-2-ce4f81c9c481@gmail.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/think-lmi.c