]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: netconsole: Populate dynamic entry even if netpoll fails
authorBreno Leitao <leitao@debian.org>
Thu, 22 Aug 2024 11:10:48 +0000 (04:10 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 26 Aug 2024 16:25:44 +0000 (09:25 -0700)
commit908ee298c8fb3f9129a470735e8bb8037a95221e
tree123dde01978ee0c82056b2d38e0fa50aad0eb842
parentae5a0456e0b4cfd7e61619e55251ffdf1bc7adfb
net: netconsole: Populate dynamic entry even if netpoll fails

Currently, netconsole discards targets that fail during initialization,
causing two issues:

1) Inconsistency between target list and configfs entries
  * user pass cmdline0, cmdline1. If cmdline0 fails, then cmdline1
    becomes cmdline0 in configfs.

2) Inability to manage failed targets from userspace
  * If user pass a target that fails with netpoll (interface not loaded at
    netcons initialization time, such as interface is a module), then
    the target will not exist in the configfs, so, user cannot re-enable
    or modify it from userspace.

Failed targets are now added to the target list and configfs, but
remain disabled until manually enabled or reconfigured. This change does
not change the behaviour if CONFIG_NETCONSOLE_DYNAMIC is not set.

CC: Aijay Adams <aijay@meta.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20240822111051.179850-3-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netconsole.c