]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mmc: renesas_sdhi: add regulator dependency
authorArnd Bergmann <arnd@arndb.de>
Sat, 29 Mar 2025 16:41:26 +0000 (17:41 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 7 Apr 2025 15:57:01 +0000 (17:57 +0200)
commit9078f01fec1275a1974a01a64a5a495d72898c60
treee56276c353acdaf14d2c13f4b52941ae8e275120
parent649b50a82f09fa44c2f7a65618e4584072145ab7
mmc: renesas_sdhi: add regulator dependency

The driver started using the regulator subsystem and fails to build without
a dependeny on CONFIG_REGULATOR:

ERROR: modpost: "rdev_get_drvdata" [drivers/mmc/host/renesas_sdhi_core.ko] undefined!
ERROR: modpost: "devm_regulator_register" [drivers/mmc/host/renesas_sdhi_core.ko] undefined!

The 'select RESET_CONTROLLER' needs to either go away or get changed to a dependency
in order to avoid Kconfig dependency loops here. It also turns out the the superh
version needs neither RESET_CONTROLLER nor REGULATOR, and this works because
CONFIG_OF is not set there.

Change both to a 'depends on', but add '|| !OF' for the superh case.

Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20250329164145.3194284-1-arnd@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/Kconfig