]> www.infradead.org Git - users/hch/misc.git/commit
nvme: remove CC register read-back during enabling
authorKeith Busch <kbusch@kernel.org>
Wed, 4 Sep 2024 21:48:50 +0000 (14:48 -0700)
committerKeith Busch <kbusch@kernel.org>
Wed, 25 Sep 2024 06:35:10 +0000 (23:35 -0700)
commit9064610348b16356d43e59e286aedfec31825541
treeb0b362f5e8e96e2d763f23957598046576341f10
parent83340d9c6178107df581c3ebbae0e28d0b15e879
nvme: remove CC register read-back during enabling

Any non-posted read should flush the previous write, so we don't
necessarily need to read back the value we just wrote. I've found at
least some controllers that respond with 0 for short moments after
writing the CC register with EN (enable) cleared, so the read-back is
overwriting our valid ctrl_config value and ends up breaking on the
subsequent enabling.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c