]> www.infradead.org Git - users/jedix/linux-maple.git/commit
block: remove redundant explicit memory barrier from rq_qos waiter and waker
authorMuchun Song <songmuchun@bytedance.com>
Mon, 21 Oct 2024 08:52:51 +0000 (16:52 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 22 Oct 2024 20:05:09 +0000 (14:05 -0600)
commit904ebd2527c507752f5ddb358f887d2e0dab96a0
treef4cd4b31081fec8d39137824defffcfd50ca5dcb
parentfdad1a20cd57bff65539d971c0ec74faf2b5b2fc
block: remove redundant explicit memory barrier from rq_qos waiter and waker

The memory barriers in list_del_init_careful() and list_empty_careful()
in pairs already handle the proper ordering between data.got_token
and data.wq.entry. So remove the redundant explicit barriers. And also
change a "break" statement to "return" to avoid redundant calling of
finish_wait().

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
Reviewed-by: Omar Sandoval <osandov@fb.com>
Link: https://lore.kernel.org/r/20241021085251.73353-1-songmuchun@bytedance.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-rq-qos.c