]> www.infradead.org Git - users/dwmw2/linux.git/commit
libfs: Return ENOSPC when the directory offset range is exhausted
authorChuck Lever <chuck.lever@oracle.com>
Sat, 28 Dec 2024 17:55:17 +0000 (12:55 -0500)
committerChristian Brauner <brauner@kernel.org>
Sat, 4 Jan 2025 09:15:51 +0000 (10:15 +0100)
commit903dc9c43a155e0893280c7472d4a9a3a83d75a6
tree6eb1c06e2020966d0ed71de097f4a48883eae1c5
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
libfs: Return ENOSPC when the directory offset range is exhausted

Testing shows that the EBUSY error return from mtree_alloc_cyclic()
leaks into user space. The ERRORS section of "man creat(2)" says:

> EBUSY O_EXCL was specified in flags and pathname refers
> to a block device that is in use by the system
> (e.g., it is mounted).

ENOSPC is closer to what applications expect in this situation.

Note that the normal range of simple directory offset values is
2..2^63, so hitting this error is going to be rare to impossible.

Fixes: 6faddda69f62 ("libfs: Add directory operations for stable offsets")
Cc: stable@vger.kernel.org # v6.9+
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Yang Erkun <yangerkun@huawei.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Link: https://lore.kernel.org/r/20241228175522.1854234-2-cel@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/libfs.c