]> www.infradead.org Git - users/jedix/linux-maple.git/commit
driver core: Make parameter check consistent for API cluster device_(for_each|find...
authorZijun Hu <quic_zijuhu@quicinc.com>
Sat, 24 Aug 2024 09:07:43 +0000 (17:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2024 11:14:59 +0000 (13:14 +0200)
commit903c44939abc02e2f3d6f2ad65fa090f7e5df5b6
tree7620f0aa2d4c00ff71df018067bd46753d07a475
parent8ab0f4605d5ce3c0d386b3828b07719f1e8e0505
driver core: Make parameter check consistent for API cluster device_(for_each|find)_child()

The following API cluster takes the same type parameter list, but do not
have consistent parameter check as shown below.

device_for_each_child(struct device *parent, ...)  // check (!parent->p)
device_for_each_child_reverse(struct device *parent, ...) // same as above
device_find_child(struct device *parent, ...)      // check (!parent)

Fixed by using consistent check (!parent || !parent->p) which covers
both existing checks for the cluster.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240824-const_dfc_prepare-v3-1-32127ea32bba@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c