]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: wd33c93: Don't use stale scsi_pointer value
authorDaniel Palmer <daniel@0x0f.com>
Thu, 3 Oct 2024 03:29:47 +0000 (13:29 +1000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 4 Oct 2024 01:48:08 +0000 (21:48 -0400)
commit9023ed8d91eb1fcc93e64dc4962f7412b1c4cbec
tree007e9dc1c27269e1782b2619f8bcf6882ea32c48
parentf30e5f77d2f205ac14d09dec40fd4bb76712f13d
scsi: wd33c93: Don't use stale scsi_pointer value

A regression was introduced with commit dbb2da557a6a ("scsi: wd33c93:
Move the SCSI pointer to private command data") which results in an oops
in wd33c93_intr(). That commit added the scsi_pointer variable and
initialized it from hostdata->connected. However, during selection,
hostdata->connected is not yet valid. Fix this by getting the current
scsi_pointer from hostdata->selecting.

Cc: Daniel Palmer <daniel@0x0f.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>
Cc: stable@kernel.org
Fixes: dbb2da557a6a ("scsi: wd33c93: Move the SCSI pointer to private command data")
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Co-developed-by: Finn Thain <fthain@linux-m68k.org>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Link: https://lore.kernel.org/r/09e11a0a54e6aa2a88bd214526d305aaf018f523.1727926187.git.fthain@linux-m68k.org
Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/wd33c93.c