]> www.infradead.org Git - mtd-utils.git/commit
mtd-utils: nanddump/nandwrite: style, signed-ness, printing fixups
authorBrian Norris <computersforpeace@gmail.com>
Thu, 21 Oct 2010 07:19:36 +0000 (00:19 -0700)
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Mon, 25 Oct 2010 19:08:54 +0000 (22:08 +0300)
commit8fe49af24eee3563d8585b7ee5f0a079fa496060
treecaf11fa6c12884e66f9c93684722f77bf73683ad
parentf5ed5cc0682ef8806279fc461b8a19946d133252
mtd-utils: nanddump/nandwrite: style, signed-ness, printing fixups

There were some signed/unsigned integer comparisons. Their types were
changed for safety. Also, "strtol" was improperly used for unsigned
data types.

Nanddump's pretty print options needed a slight reformat to prepare for
printing offsets that are more than 32 bits (8 hex characters) wide.
This prevents overlap of output and ensures that at least one space is
printed between hex and ascii printouts. Perhaps this could use some
better alignment in the future.

Other fixes:
* Corrected several simple spacing issues
* Changed indentation of some global variable declarations in
  order to prepare for the next patch, which makes those
  declarations longer
* Used macro for PRETTY_ROW_SIZE instead of constant 16
* Reformatted, edited a multi-line comment
* Removed some unnecessary casts

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
nanddump.c
nandwrite.c