]> www.infradead.org Git - users/dwmw2/qemu.git/commit
hw/net/eepro100: Fix endianness problem on big endian hosts
authorThomas Huth <thuth@redhat.com>
Thu, 16 Nov 2017 21:16:54 +0000 (22:16 +0100)
committerJason Wang <jasowang@redhat.com>
Mon, 20 Nov 2017 03:08:00 +0000 (11:08 +0800)
commit8f8e8053d9cc9f64f739ad64fa6ac83a4d9555f6
tree53a20a0771fa06b4a34fe36cdeb52a0af6c63be3
parent2ec405524e85a1f6caba49dbb1fdf7c56e732b00
hw/net/eepro100: Fix endianness problem on big endian hosts

Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission
mode"), the test/pxe-test is broken for the eepro100 device on big
endian hosts. However, it seems like that commit did not introduce the
problem, but just uncovered it: The EEPRO100State->tx.tbd_array_addr and
EEPRO100State->tx.tcb_bytes fields are already in host byte order, since
they have already been byte-swapped in the read_cb() function.
Thus byte-swapping them in tx_command() again results in the wrong
endianness. Removing the byte-swapping here fixes the pxe-test.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/eepro100.c