]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pinctrl: single: fix possible memory leak when pinctrl_enable() fails
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 6 Jun 2024 02:37:03 +0000 (10:37 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Jun 2024 08:33:30 +0000 (10:33 +0200)
commit8f773bfbdd428819328a2d185976cfc6ae811cd3
tree843de7da624d6df1e1b283719d78e19e4c22fcff
parentae1cf4759972c5fe665ee4c5e0c29de66fe3cf4a
pinctrl: single: fix possible memory leak when pinctrl_enable() fails

This driver calls pinctrl_register_and_init() which is not
devm_ managed, it will leads memory leak if pinctrl_enable()
fails. Replace it with devm_pinctrl_register_and_init().
And call pcs_free_resources() if pinctrl_enable() fails.

Fixes: 5038a66dad01 ("pinctrl: core: delete incorrect free in pinctrl_enable()")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240606023704.3931561-3-yangyingliang@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-single.c