]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm/memfd: use strncpy_from_user() to read memfd name
authorIsaac J. Manjarres <isaacmanjarres@google.com>
Fri, 10 Jan 2025 16:59:00 +0000 (08:59 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 26 Jan 2025 04:22:40 +0000 (20:22 -0800)
commit8f65ac0b7577a9691ed838c95e514ce287d8e36e
tree5784b9b45c96c18fc3afb4ca9fb3026b79b65c2a
parentf5dbcd90dacd39ecd17fca86b47f52be6ffdd179
mm/memfd: use strncpy_from_user() to read memfd name

The existing logic uses strnlen_user() to calculate the length of the
memfd name from userspace and then copies the string into a buffer using
copy_from_user().  This is error-prone, as the string length could have
changed between the time when it was calculated and when the string was
copied.  The existing logic handles this by ensuring that the last byte in
the buffer is the terminating zero.

This handling is contrived and can better be handled by using
strncpy_from_user(), which gets the length of the string and copies it in
one shot.  Therefore, simplify the logic for copying the memfd name by
using strncpy_from_user().

No functional change.

Link: https://lkml.kernel.org/r/20250110165904.3437374-3-isaacmanjarres@google.com
Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: John Stultz <jstultz@google.com>
Cc: Kalesh Singh <kaleshsingh@google.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memfd.c