]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: Remove redundant variable declaration in __dev_change_flags()
authorBreno Leitao <leitao@debian.org>
Mon, 17 Feb 2025 15:48:13 +0000 (07:48 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 19 Feb 2025 02:10:56 +0000 (18:10 -0800)
commit8f02c48f8f623eedc3c0a26a64c7ef155c35bfb9
tree88216a9f48639dbf947d6e9a5ca14b526476968a
parentf29e41454b94e6e4f3cdf340947b61fd22950c96
net: Remove redundant variable declaration in __dev_change_flags()

The old_flags variable is declared twice in __dev_change_flags(),
causing a shadow variable warning. This patch fixes the issue by
removing the redundant declaration, reusing the existing old_flags
variable instead.

net/core/dev.c:9225:16: warning: declaration shadows a local variable [-Wshadow]
9225 |                 unsigned int old_flags = dev->flags;
|                              ^
net/core/dev.c:9185:15: note: previous declaration is here
9185 |         unsigned int old_flags = dev->flags;
|                      ^
1 warning generated.

Remove the redundant inner declaration and reuse the existing old_flags
variable since its value is not needed outside the if block, and it is
safe to reuse the variable. This eliminates the warning while
maintaining the same functionality.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250217-old_flags-v2-1-4cda3b43a35f@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c