]> www.infradead.org Git - users/hch/configfs.git/commit
ice: Fix netif_is_ice() in Safe Mode
authorMarcin Szycik <marcin.szycik@linux.intel.com>
Tue, 24 Sep 2024 10:04:24 +0000 (12:04 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 8 Oct 2024 21:08:19 +0000 (14:08 -0700)
commit8e60dbcbaaa177dacef55a61501790e201bf8c88
tree2c1635a006d5b13ad8d92ad913436ddebbfddee4
parentb972060a47780aa2d46441e06b354156455cc877
ice: Fix netif_is_ice() in Safe Mode

netif_is_ice() works by checking the pointer to netdev ops. However, it
only checks for the default ice_netdev_ops, not ice_netdev_safe_mode_ops,
so in Safe Mode it always returns false, which is unintuitive. While it
doesn't look like netif_is_ice() is currently being called anywhere in Safe
Mode, this could change and potentially lead to unexpected behaviour.

Fixes: df006dd4b1dc ("ice: Add initial support framework for LAG")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c