]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value
authorLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 29 Nov 2018 09:55:59 +0000 (09:55 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 08:28:53 +0000 (09:28 +0100)
commit8e3f3c06be02aaf0b09f11eafc3e2f567bdbd6d2
tree77ca63f10682463f0500277d00dce1cd9b076df5
parent9407fd14d0ee929ea21571055ccf4361b6e2323a
ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value

[ Upstream commit ea2412dc21cc790335d319181dddc43682aef164 ]

Running the Clang static analyzer on IORT code detected the following
error:

Logic error: Branch condition evaluates to a garbage value

in

iort_get_platform_device_domain()

If the named component associated with a given device has no IORT
mappings, iort_get_platform_device_domain() exits its MSI mapping loop
with msi_parent pointer containing garbage, which can lead to erroneous
code path execution.

Initialize the msi_parent pointer, fixing the bug.

Fixes: d4f54a186667 ("ACPI: platform: setup MSI domain for ACPI based
platform device")
Reported-by: Patrick Bellasi <patrick.bellasi@arm.com>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/arm64/iort.c