]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dlm: prevent NPD when writing a positive value to event_done
authorThadeu Lima de Souza Cascardo <cascardo@igalia.com>
Mon, 10 Feb 2025 19:16:22 +0000 (13:16 -0600)
committerDavid Teigland <teigland@redhat.com>
Mon, 10 Feb 2025 19:18:04 +0000 (13:18 -0600)
commit8e2bad543eca5c25cd02cbc63d72557934d45f13
treef93539f9bf768a86ba626ed7f7eb76c24b74d365
parenta53a6336171bd722aac6e98964a79d56841c5416
dlm: prevent NPD when writing a positive value to event_done

do_uevent returns the value written to event_done. In case it is a
positive value, new_lockspace would undo all the work, and lockspace
would not be set. __dlm_new_lockspace, however, would treat that
positive value as a success due to commit 8511a2728ab8 ("dlm: fix use
count with multiple joins").

Down the line, device_create_lockspace would pass that NULL lockspace to
dlm_find_lockspace_local, leading to a NULL pointer dereference.

Treating such positive values as successes prevents the problem. Given
this has been broken for so long, this is unlikely to break userspace
expectations.

Fixes: 8511a2728ab8 ("dlm: fix use count with multiple joins")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lockspace.c