]> www.infradead.org Git - users/hch/misc.git/commit
vma: detect infinite loop in vma tree
authorLiam R. Howlett <Liam.Howlett@Oracle.com>
Thu, 31 Oct 2024 19:36:08 +0000 (15:36 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 11 Nov 2024 21:09:42 +0000 (13:09 -0800)
commit8e1817b6ba97c3d92d163447226cf6a0c1f90723
treed056f392ad5e593f537b516f4d404bb1f336a948
parent4175eff0e007b3b781f45742551393736346755d
vma: detect infinite loop in vma tree

There have been no reported infinite loops in the tree, but checking the
detection of an infinite loop during validation is simple enough.  Add the
detection to the validate_mm() function so that error reports are clear
and don't just report stalls.

This does not protect against internal maple tree issues, but it does
detect too many vmas being returned from the tree.

The variance of +10 is to allow for the debugging output to be more useful
for nearly correct counts.  In the event of more than 10 over the
map_count, the count will be set to -1 for easier identification of a
potential infinite loop.

Note that the mmap lock is held to ensure a consistent tree state during
the validation process.

[akpm@linux-foundation.org: add comment]
Link: https://lkml.kernel.org/r/20241031193608.1965366-1-Liam.Howlett@oracle.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Jann Horn <jannh@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/vma.c