]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: endpoint: Clean up error handling in vpci_scan_bus()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 10 Jun 2024 09:33:39 +0000 (12:33 +0300)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Thu, 4 Jul 2024 14:40:53 +0000 (14:40 +0000)
commit8e0f5a96c534f781e8c57ca30459448b3bfe5429
tree517101e711fd5a87317239352330598fc85eb70c
parent03377a698926e829321fcd42789892cb5974b6b6
PCI: endpoint: Clean up error handling in vpci_scan_bus()

Smatch complains about inconsistent NULL checking in vpci_scan_bus():

    drivers/pci/endpoint/functions/pci-epf-vntb.c:1024 vpci_scan_bus() error: we previously assumed 'vpci_bus' could be null (see line 1021)

Instead of printing an error message and then crashing we should return
an error code and clean up.

Also the NULL check is reversed so it prints an error for success
instead of failure.

Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
Link: https://lore.kernel.org/linux-pci/68e0f6a4-fd57-45d0-945b-0876f2c8cb86@moroto.mountain
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/pci/endpoint/functions/pci-epf-vntb.c