]> www.infradead.org Git - users/dwmw2/linux.git/commit
pinctrl: qcom: spmi-gpio: drop broken pm8008 support
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 29 May 2024 16:29:52 +0000 (18:29 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Jun 2024 07:16:54 +0000 (09:16 +0200)
commit8da86499d4cd125a9561f9cd1de7fba99b0aecbf
treeaa9ce3062eb7bdd97870932de8b4fd05593c4092
parentdff5c3de21e753d1e46517aa2df0ebd23c06ede5
pinctrl: qcom: spmi-gpio: drop broken pm8008 support

The SPMI GPIO driver assumes that the parent device is an SPMI device
and accesses random data when backcasting the parent struct device
pointer for non-SPMI devices.

Fortunately this does not seem to cause any issues currently when the
parent device is an I2C client like the PM8008, but this could change if
the structures are reorganised (e.g. using structure randomisation).

Notably the interrupt implementation is also broken for non-SPMI devices.

Also note that the two GPIO pins on PM8008 are used for interrupts and
reset so their practical use should be limited.

Drop the broken GPIO support for PM8008 for now.

Fixes: ea119e5a482a ("pinctrl: qcom-pmic-gpio: Add support for pm8008")
Cc: stable@vger.kernel.org # 5.13
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20240529162958.18081-9-johan+linaro@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c