]> www.infradead.org Git - users/jedix/linux-maple.git/commit
Bluetooth: cmtp: fix file refcount when cmtp_attach_device fails
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 13 Apr 2021 16:21:03 +0000 (13:21 -0300)
committerMarcel Holtmann <marcel@holtmann.org>
Tue, 4 May 2021 13:20:31 +0000 (15:20 +0200)
commit8da3a0b87f4f1c3a3bbc4bfb78cf68476e97d183
tree20683a11e04fe69bdfe2086cd99371360b25d742
parent4f46690dedfb7ae382aa09b858fde7f022baadd3
Bluetooth: cmtp: fix file refcount when cmtp_attach_device fails

When cmtp_attach_device fails, cmtp_add_connection returns the error value
which leads to the caller to doing fput through sockfd_put. But
cmtp_session kthread, which is stopped in this path will also call fput,
leading to a potential refcount underflow or a use-after-free.

Add a refcount before we signal the kthread to stop. The kthread will try
to grab the cmtp_session_sem mutex before doing the fput, which is held
when get_file is called, so there should be no races there.

Reported-by: Ryota Shiga
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/cmtp/core.c