]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sparc64: fix incorrect sign extension in sys_sparc64_personality
authorDmitry V. Levin <ldv@altlinux.org>
Sat, 26 Dec 2015 23:13:27 +0000 (02:13 +0300)
committerAllen Pais <allen.pais@oracle.com>
Thu, 4 Feb 2016 13:10:55 +0000 (18:40 +0530)
commit8d7598b43c2f114c84ab10664f3e01d320f21b51
treef24df8ed2ba3d11b9d839fd1aaeba13b773e8b02
parente451b7c12ff92b0c1d55cb63bc93a073ef1b127b
sparc64: fix incorrect sign extension in sys_sparc64_personality

The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from sys_sparc64_personality.

For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0xffffffff) call, failing with
errno set to EINVAL.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 525fd5a94e1be0776fa652df5c687697db508c91)
Signed-off-by: Allen Pais <allen.pais@oracle.com>
arch/sparc/kernel/sys_sparc_64.c