]> www.infradead.org Git - users/dwmw2/linux.git/commit
pds_core: limit loop over fw name list
authorShannon Nelson <shannon.nelson@amd.com>
Fri, 3 Jan 2025 19:51:47 +0000 (11:51 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 6 Jan 2025 23:57:54 +0000 (15:57 -0800)
commit8c817eb26230dc0ae553cee16ff43a4a895f6756
tree4c0f866f64276f0f039e76c1bba9b13f343cb61c
parent8ce4f287524c74a118b0af1eebd4b24a8efca57a
pds_core: limit loop over fw name list

Add an array size limit to the for-loop to be sure we don't try
to reference a fw_version string off the end of the fw info names
array.  We know that our firmware only has a limited number
of firmware slot names, but we shouldn't leave this unchecked.

Fixes: 45d76f492938 ("pds_core: set up device and adminq")
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250103195147.7408-1-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/pds_core/devlink.c