]> www.infradead.org Git - users/hch/misc.git/commit
cfi: fix conditions for HAVE_CFI_ICALL_NORMALIZE_INTEGERS
authorAlice Ryhl <aliceryhl@google.com>
Thu, 10 Oct 2024 09:38:27 +0000 (09:38 +0000)
committerMiguel Ojeda <ojeda@kernel.org>
Sun, 13 Oct 2024 20:23:13 +0000 (22:23 +0200)
commit8b8ca9c25fe69c2162e3235c7d6c341127abeed6
treedfa5000a62e26a678291c960408368b253a9e85f
parentaf0121c2d303111d363c62e40413ffb39d5dc0f1
cfi: fix conditions for HAVE_CFI_ICALL_NORMALIZE_INTEGERS

The HAVE_CFI_ICALL_NORMALIZE_INTEGERS option has some tricky conditions
when KASAN or GCOV are turned on, as in that case we need some clang and
rustc fixes [1][2] to avoid boot failures. The intent with the current
setup is that you should be able to override the check and turn on the
option if your clang/rustc has the fix. However, this override does not
work in practice. Thus, use the new RUSTC_LLVM_VERSION to correctly
implement the check for whether the fix is available.

Additionally, remove KASAN_HW_TAGS from the list of incompatible
options. The CFI_ICALL_NORMALIZE_INTEGERS option is incompatible with
KASAN because LLVM will emit some constructors when using KASAN that are
assigned incorrect CFI tags. These constructors are emitted due to use
of -fsanitize=kernel-address or -fsanitize=kernel-hwaddress that are
respectively passed when KASAN_GENERIC or KASAN_SW_TAGS are enabled.
However, the KASAN_HW_TAGS option relies on hardware support for MTE
instead and does not pass either flag. (Note also that KASAN_HW_TAGS
does not `select CONSTRUCTORS`.)

Link: https://github.com/llvm/llvm-project/pull/104826
Link: https://github.com/rust-lang/rust/pull/129373
Fixes: 4c66f8307ac0 ("cfi: encode cfi normalized integers + kasan/gcov bug in Kconfig")
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Link: https://lore.kernel.org/r/20241010-icall-detect-vers-v1-2-8f114956aa88@google.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
arch/Kconfig
init/Kconfig