]> www.infradead.org Git - users/dwmw2/linux.git/commit
i2c: npcm: Enable slave in eob interrupt
authorCharles Boyer <Charles.Boyer@fii-usa.com>
Thu, 19 Dec 2024 09:08:59 +0000 (17:08 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 7 Jan 2025 22:46:10 +0000 (23:46 +0100)
commit8b56f98b28e6238bcfe00de743b4361d26a7f980
treeaacb45df34e244972c962d7f5780945b36f4d3cc
parent6ddc9132bc42a7dfcaca0cce4ff0f94e69bc5114
i2c: npcm: Enable slave in eob interrupt

Nuvoton slave enable was in user space API call master_xfer, so it is
subject to delays from the OS scheduler. If the BMC is not enabled for
slave mode in time for master to send response, then it will NAK the
address match. Then the PLDM request timeout occurs.

If the slave enable is moved to the EOB interrupt service routine, then
the BMC can be ready in slave mode by the time it needs to receive a
response.

Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com>
Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
Reviewed-by: Tali Perry <tali.perry1@gmail.com>
Link: https://lore.kernel.org/r/20241219090859.18722-5-kfting@nuvoton.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-npcm7xx.c