]> www.infradead.org Git - users/jedix/linux-maple.git/commit
USB: serial: ftdi_sio: Fix atomicity violation in get_serial_info()
authorQiu-ji Chen <chenqiuji666@gmail.com>
Thu, 7 Nov 2024 11:35:34 +0000 (19:35 +0800)
committerJohan Hovold <johan@kernel.org>
Thu, 7 Nov 2024 16:21:10 +0000 (17:21 +0100)
commit8b524944f92ccad925b574f645e9c2709cf60d1e
tree8b4f0e78877f197e396507ecee74f797105bcb7f
parent40827729cff16269b5e99fc8e12bf53d848407de
USB: serial: ftdi_sio: Fix atomicity violation in get_serial_info()

Our static checker found a bug where set_serial_info() uses a mutex, but
get_serial_info() does not. Fortunately, the impact of this is relatively
minor. It doesn't cause a crash or any other serious issues. However, if a
race condition occurs between set_serial_info() and get_serial_info(),
there is a chance that the data returned by get_serial_info() will be
inconsistent.

Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()")
Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/ftdi_sio.c