]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: ti: icssg-prueth: Fix kernel panic during concurrent Tx queue access
authorMeghana Malladi <m-malladi@ti.com>
Tue, 6 May 2025 11:05:45 +0000 (16:35 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 May 2025 01:19:11 +0000 (18:19 -0700)
commit8b3fae3e2376b70b7a76005263bc34d034b9c7bf
tree1643b5844435c6eb61b71830ccca4f690556670c
parente5641daa0ea1932e2b0fa7f27843e712244f6538
net: ti: icssg-prueth: Fix kernel panic during concurrent Tx queue access

Add __netif_tx_lock() to ensure that only one packet is being
transmitted at a time to avoid race conditions in the netif_txq
struct and prevent packet data corruption. Failing to do so causes
kernel panic with the following error:

[ 2184.746764] ------------[ cut here ]------------
[ 2184.751412] kernel BUG at lib/dynamic_queue_limits.c:99!
[ 2184.756728] Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMPT SMP

logs: https://gist.github.com/MeghanaMalladiTI/9c7aa5fc3b7fb03f87c74aad487956e9

The lock is acquired before calling emac_xmit_xdp_frame() and released after the
call returns. This ensures that the TX queue is protected from concurrent access
during the transmission of XDP frames.

Fixes: 62aa3246f462 ("net: ti: icssg-prueth: Add XDP support")
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250506110546.4065715-3-m-malladi@ti.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/icssg/icssg_common.c
drivers/net/ethernet/ti/icssg/icssg_prueth.c