]> www.infradead.org Git - users/dwmw2/linux.git/commit
lib: packing: refuse operating on bit indices which exceed size of buffer
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 2 Oct 2024 21:51:50 +0000 (14:51 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 22:32:03 +0000 (15:32 -0700)
commit8b3e26677bc64d42d2f38d9abc8dccc09d8a4259
tree45fdf74fbb91eaefa3614816c319c50031a3eb75
parentf66ebf37d69cc700ca884c6a18c2258caf8b151b
lib: packing: refuse operating on bit indices which exceed size of buffer

While reworking the implementation, it became apparent that this check
does not exist.

There is no functional issue yet, because at call sites, "startbit" and
"endbit" are always hardcoded to correct values, and never come from the
user.

Even with the upcoming support of arbitrary buffer lengths, the
"startbit >= 8 * pbuflen" check will remain correct. This is because
we intend to always interpret the packed buffer in a way that avoids
discontinuities in the available bit indices.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20241002-packing-kunit-tests-and-split-pack-unpack-v2-1-8373e551eae3@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
lib/packing.c