]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: fix ACPI warning when resume
authorBaochen Qiang <quic_bqiang@quicinc.com>
Tue, 11 Jun 2024 06:42:33 +0000 (09:42 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Tue, 11 Jun 2024 18:36:22 +0000 (21:36 +0300)
commit8b2a12749b08726f006303814ecc1c37024d3617
tree1ad887d3ed774107e23bbe60e9584163dc135db9
parent4938ba733ee2147724c4b10025fe0d349d3b605f
wifi: ath12k: fix ACPI warning when resume

Currently ACPI notification handler is installed when driver loads and only
gets removed when driver unloads. During resume after firmware is reloaded,
ath12k tries to install it by default. Since it is installed already, ACPI
subsystem rejects it and returns an error:

[   83.094206] ath12k_pci 0000:03:00.0: failed to install DSM notify callback: 7

Fix it by removing that handler when going to suspend. This also avoid any
possible ACPI call to firmware before firmware is reloaded/reinitialized.

Note ab->acpi also needs to be cleared in ath12k_acpi_stop() such that we
are in a clean state when ACPI structures are reinitialized in
ath12k_acpi_start().

Tested-on: WCN7850 HW2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Fixes: 576771c9fa21 ("wifi: ath12k: ACPI TAS support")
Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240531024000.9291-1-quic_bqiang@quicinc.com
drivers/net/wireless/ath/ath12k/acpi.c
drivers/net/wireless/ath/ath12k/core.c