]> www.infradead.org Git - users/jedix/linux-maple.git/commit
Bluetooth: qca: If memdump doesn't work, re-enable IBS
authorDouglas Anderson <dianders@chromium.org>
Wed, 21 Aug 2024 22:43:40 +0000 (15:43 -0700)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 30 Aug 2024 21:48:24 +0000 (17:48 -0400)
commit8ae22de9d2eae3c432de64bf2b3a5a69cf1d1124
treea4495e7accff05e163c36366b77d53f24d5efe8e
parentfe1910f9337bd46a9343967b547ccab26b4b2c6e
Bluetooth: qca: If memdump doesn't work, re-enable IBS

On systems in the field, we are seeing this sometimes in the kernel logs:
  Bluetooth: qca_controller_memdump() hci0: hci_devcd_init Return:-95

This means that _something_ decided that it wanted to get a memdump
but then hci_devcd_init() returned -EOPNOTSUPP (AKA -95).

The cleanup code in qca_controller_memdump() when we get back an error
from hci_devcd_init() undoes most things but forgets to clear
QCA_IBS_DISABLED. One side effect of this is that, during the next
suspend, qca_suspend() will always get a timeout.

Let's fix it so that we clear the bit.

Fixes: 06d3fdfcdf5c ("Bluetooth: hci_qca: Add qcom devcoredump support")
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/hci_qca.c