]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bpf: tcp: Mark bpf_load_hdr_opt() arg2 as read-write
authorDaniel Xu <dxu@dxuuu.xyz>
Tue, 14 Jan 2025 20:28:43 +0000 (13:28 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 17 Jan 2025 01:51:10 +0000 (17:51 -0800)
commit8ac412a3361173e3000b16167af3d1f6f90af613
tree27c3dee9bea00312254e869aa5925d1851cd750f
parentb8a81b5dd6450be730924ea5e78f5892927cccd1
bpf: tcp: Mark bpf_load_hdr_opt() arg2 as read-write

MEM_WRITE attribute is defined as: "Non-presence of MEM_WRITE means that
MEM is only being read". bpf_load_hdr_opt() both reads and writes from
its arg2 - void *search_res.

This matters a lot for the next commit where we more precisely track
stack accesses. Without this annotation, the verifier will make false
assumptions about the contents of memory written to by helpers and
possibly prune valid branches.

Fixes: 6fad274f06f0 ("bpf: Add MEM_WRITE attribute")
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Link: https://lore.kernel.org/r/730e45f8c39be2a5f3d8c4406cceca9d574cbf14.1736886479.git.dxu@dxuuu.xyz
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/filter.c