]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: hisi_sas: Enable force phy when SATA disk directly connected
authorXingui Yang <yangxingui@huawei.com>
Wed, 12 Mar 2025 09:51:34 +0000 (17:51 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 Mar 2025 00:46:31 +0000 (20:46 -0400)
commit8aa580cd92843b60d4d6331f3b0a9e8409bb70eb
tree4bad162ea26f95be78e76b2957d3898fb68847f7
parent8db816c6f176321e42254badd5c1a8df8bfcfdb4
scsi: hisi_sas: Enable force phy when SATA disk directly connected

when a SATA disk is directly connected the SAS controller determines the
disk to which I/Os are delivered based on the port ID in the DQ entry.

When many phys are disconnected and reconnect, the port ID of phys were
changed and used by other link, resulting in I/O being sent to incorrect
disk. Data inconsistency on the SATA disk may occur during I/O retries
using the old port ID. So enable force phy, then force the command to be
executed in a certain phy, and if the actual phy ID of the port does not
match the phy configured in the command, the chip will stop delivering the
I/O to disk.

Fixes: ce60689e12dd ("scsi: hisi_sas: add v3 code to send ATA frame")
Signed-off-by: Xingui Yang <yangxingui@huawei.com>
Link: https://lore.kernel.org/r/20250312095135.3048379-2-yangxingui@huawei.com
Reviewed-by: Yihang Li <liyihang9@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c