]> www.infradead.org Git - users/hch/dma-mapping.git/commit
net: sparx5: fix source port register when mirroring
authorDaniel Machon <daniel.machon@microchip.com>
Wed, 9 Oct 2024 12:49:56 +0000 (14:49 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Oct 2024 22:42:51 +0000 (15:42 -0700)
commit8a6be4bd6fb319cee63d228e37c8dda5fd1eb74a
treed8eb39743592e0301443cba686450c256cf64921
parent22600596b6756b166fd052d5facb66287e6f0bad
net: sparx5: fix source port register when mirroring

When port mirroring is added to a port, the bit position of the source
port, needs to be written to the register ANA_AC_PROBE_PORT_CFG.  This
register is replicated for n_ports > 32, and therefore we need to derive
the correct register from the port number.

Before this patch, we wrongly calculate the register from portno /
BITS_PER_BYTE, where the divisor ought to be 32, causing any port >=8 to
be written to the wrong register. We fix this, by using do_div(), where
the dividend is the register, the remainder is the bit position and the
divisor is now 32.

Fixes: 4e50d72b3b95 ("net: sparx5: add port mirroring implementation")
Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241009-mirroring-fix-v1-1-9ec962301989@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/sparx5/sparx5_mirror.c