]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: remove return for empty tx bitrate in mac_op_sta_statistics
authorRemi Pommarel <repk@triplefau.lt>
Wed, 29 Jan 2025 16:55:17 +0000 (17:55 +0100)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Fri, 31 Jan 2025 19:32:31 +0000 (11:32 -0800)
commit8a5ad319f2e6f0462dbcb1bd3a6ba5097f629a5b
tree398010351ee10210d50db94c3c331b3558274199
parentdf11edfba49e5fb69f4c9e7cb76082b89c417f78
wifi: ath12k: remove return for empty tx bitrate in mac_op_sta_statistics

Currently in ath12k_mac_op_sta_statistics() there is the following
logic:

    if (!arsta->txrate.legacy && !arsta->txrate.nss)
        return;

Because ath12k_sta_statistics is used to report many info to iw wlan0 link,
if it return for empty legacy and nss of arsta->txrate, then the other
stats after it will not be set.

To address this issue remove the return and instead invert the logic to set
the txrate logic if (arsta->txrate.legacy || arsta->txrate.nss).

The same was done also in both ath10k with commit 1cd6ba8ae33e ("ath10k:
remove return for NL80211_STA_INFO_TX_BITRATE") and ath11k as well with
commit 1d795645e1ee ("ath11k: remove return for empty tx bitrate in
mac_op_sta_statistics").

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Link: https://patch.msgid.link/38c2a7c4f7eaf57b9306bb95a9e6c42b7d987e05.1738169458.git.repk@triplefau.lt
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/mac.c