]> www.infradead.org Git - users/jedix/linux-maple.git/commit
gpiolib: don't double-check the gc->get callback's existence
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 26 Feb 2025 10:12:31 +0000 (11:12 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 27 Feb 2025 07:57:50 +0000 (08:57 +0100)
commit8a5680bffb2f681688b5788751c767fc380ff9b7
treed2e432302e63a907e3225529a7585891adca0198
parentcc78604fd4799a8e8e9d23ea4898acd6b605982d
gpiolib: don't double-check the gc->get callback's existence

gpiochip_get() is called only in two places: in gpio_chip_get_value()
and in gpiochip_get_multiple() where the existence of the gc->get()
callback is already checked. It makes sense to unduplicate the check by
moving it one level up the stack.

Fixes: 86ef402d805d ("gpiolib: sanitize the return value of gpio_chip::get()")
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Closes: https://lore.kernel.org/all/Z7yekJ8uRh8dphKn@black.fi.intel.com/
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250226-retval-fixes-v2-3-c8dc57182441@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib.c