]> www.infradead.org Git - users/hch/block.git/commit
net: sparx5: Fix use after free inside sparx5_del_mact_entry
authorHoratiu Vultur <horatiu.vultur@microchip.com>
Fri, 1 Mar 2024 08:06:08 +0000 (09:06 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 5 Mar 2024 04:38:22 +0000 (20:38 -0800)
commit89d72d4125e94aa3c2140fedd97ce07ba9e37674
treedd727108975bc52cc6eb4990868a8be56adcb955
parent948abb59ebd3892c425165efd8fb2f5954db8de7
net: sparx5: Fix use after free inside sparx5_del_mact_entry

Based on the static analyzis of the code it looks like when an entry
from the MAC table was removed, the entry was still used after being
freed. More precise the vid of the mac_entry was used after calling
devm_kfree on the mac_entry.
The fix consists in first using the vid of the mac_entry to delete the
entry from the HW and after that to free it.

Fixes: b37a1bae742f ("net: sparx5: add mactable support")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240301080608.3053468-1-horatiu.vultur@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c