]> www.infradead.org Git - users/dwmw2/linux.git/commit
binfmt_elf: Do not move brk for INTERP-less ET_EXEC
authorKees Cook <keescook@chromium.org>
Thu, 26 Sep 2019 17:15:25 +0000 (10:15 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 11:14:05 +0000 (13:14 +0200)
commit89beb34d7533f778c3f04f948ee648a677e50a8c
treeb423113d52c572233684e3f653e0a015007837b9
parenta24d7c499db0653e68bf5d8e0cdaac243082d87f
binfmt_elf: Do not move brk for INTERP-less ET_EXEC

commit 7be3cb019db1cbd5fd5ffe6d64a23fefa4b6f229 upstream.

When brk was moved for binaries without an interpreter, it should have
been limited to ET_DYN only. In other words, the special case was an
ET_DYN that lacks an INTERP, not just an executable that lacks INTERP.
The bug manifested for giant static executables, where the brk would end
up in the middle of the text area on 32-bit architectures.

Reported-and-tested-by: Richard Kojedzinszky <richard@kojedz.in>
Fixes: bbdc6076d2e5 ("binfmt_elf: move brk out of mmap when doing direct loader exec")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/binfmt_elf.c