]> www.infradead.org Git - users/jedix/linux-maple.git/commit
RDS: don't call rds_conn_shutdown() from rds_conn_destroy()
authorZach Brown <zach.brown@oracle.com>
Fri, 23 Jul 2010 17:36:58 +0000 (10:36 -0700)
committerMukesh Kacker <mukesh.kacker@oracle.com>
Tue, 7 Jul 2015 23:41:26 +0000 (16:41 -0700)
commit8956a6cd08a3d139b2f3b83585ee4304c216cd6e
treeca7a26641a1be9f5a62f01e5f1797841502027ab
parentb768e45d4be0a49525bfb8fed1c1af21616172d2
RDS: don't call rds_conn_shutdown() from rds_conn_destroy()

rds_conn_shutdown() can return before the connection is shut down when
it encounters an existing state that it doesn't understand.  This lets
rds_conn_destroy() then start tearing down the conn from under paths
that are still using it.

It's more reliable the shutdown work and wait for krdsd to complete the
shutdown callback.  This stopped some hangs I was seeing where krdsd was
trying to shut down a freed conn.

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Signed-off-by: Bang Nguyen <bang.nguyen@oracle.com>
net/rds/connection.c