]> www.infradead.org Git - users/hch/misc.git/commit
selftests: mptcp: simult_flows: unify errors msgs
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 14 Jan 2025 18:03:11 +0000 (19:03 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 15 Jan 2025 21:21:14 +0000 (13:21 -0800)
commit894dae026bf6348766cf1951da63af6e36e4d90a
treed136db7dab19d7425b11d3c6209980edd784387b
parent0e6f1c77ba808e7bf023627ae2927fa813214455
selftests: mptcp: simult_flows: unify errors msgs

In order to unify what is printed in case of error, similar to what is
done in mptcp_connect.sh and mptcp_join.sh, it is interesting to do the
following modifications in simult_flows.sh:

- Print the rc errors at the end of the line.

- Print the MIB counters.

- Use the same ss options: add -M (MPTCP sockets) and -e (detailed
  socket information).

While at it, also print of the 'max' time only in case of success,
because 'mptcp_connect.c' will already print this info in case of error,
e.g.:

  transfer slower than expected! runtime 11948 ms, expected 11921 ms

Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250114-net-next-mptcp-st-more-debug-err-v1-1-2ffb16a6cf35@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/simult_flows.sh