]> www.infradead.org Git - users/hch/xfs.git/commit
virtio_console: fix misc probe bugs
authorMichael S. Tsirkin <mst@redhat.com>
Mon, 16 Sep 2024 18:16:44 +0000 (14:16 -0400)
committerChristoph Hellwig <hch@lst.de>
Tue, 8 Oct 2024 05:03:13 +0000 (07:03 +0200)
commit89245056d9269d62b9c5718edf9c0b51de260d07
treeb6eb53015536ae423103a20c843e61c26d788e5f
parent9073ff17fc30c58cbb7ab2570fa07e31b8e9dd54
virtio_console: fix misc probe bugs

This fixes the following issue discovered by code review:

after vqs have been created, a buggy device can send an interrupt.

A control vq callback will then try to schedule control_work which has
not been initialized yet. Similarly for config interrupt.  Further, in
and out vq callbacks invoke find_port_by_vq which attempts to take
ports_lock which also has not been initialized.

To fix, init all locks and work before creating vqs.

Message-ID: <ad982e975a6160ad110c623c016041311ca15b4f.1726511547.git.mst@redhat.com>
Fixes: 17634ba25544 ("virtio: console: Add a new MULTIPORT feature, support for generic ports")
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/char/virtio_console.c