]> www.infradead.org Git - users/dwmw2/linux.git/commit
dmaengine: idxd: Register dsa_bus_type before registering idxd sub-drivers
authorFenghua Yu <fenghua.yu@intel.com>
Sun, 24 Sep 2023 16:22:32 +0000 (09:22 -0700)
committerVinod Koul <vkoul@kernel.org>
Thu, 28 Sep 2023 07:56:34 +0000 (13:26 +0530)
commit88928addeec577386e8c83b48b5bc24d28ba97fd
treea1bea006a0bf13e7ebe3fdca3962f2127cf15a36
parent555921feb2ac03d88647ccc62015e68f157c30a2
dmaengine: idxd: Register dsa_bus_type before registering idxd sub-drivers

idxd sub-drivers belong to bus dsa_bus_type. Thus, dsa_bus_type must be
registered in dsa bus init before idxd drivers can be registered.

But the order is wrong when both idxd and idxd_bus are builtin drivers.
In this case, idxd driver is compiled and linked before idxd_bus driver.
Since the initcall order is determined by the link order, idxd sub-drivers
are registered in idxd initcall before dsa_bus_type is registered
in idxd_bus initcall. idxd initcall fails:

[   21.562803] calling  idxd_init_module+0x0/0x110 @ 1
[   21.570761] Driver 'idxd' was unable to register with bus_type 'dsa' because the bus was not initialized.
[   21.586475] initcall idxd_init_module+0x0/0x110 returned -22 after 15717 usecs
[   21.597178] calling  dsa_bus_init+0x0/0x20 @ 1

To fix the issue, compile and link idxd_bus driver before idxd driver
to ensure the right registration order.

Fixes: d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")
Reported-by: Michael Prinke <michael.prinke@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Lijun Pan <lijun.pan@intel.com>
Tested-by: Lijun Pan <lijun.pan@intel.com>
Link: https://lore.kernel.org/r/20230924162232.1409454-1-fenghua.yu@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/Makefile