]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: uvcvideo: Allow changing noparam on the fly
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 18 Dec 2024 21:39:10 +0000 (21:39 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 19 Dec 2024 14:44:43 +0000 (14:44 +0000)
commit8869eb654f2a7abb2dcdb79606fc95a4f092a449
tree1075ad266730072071e7221c98074ebaf7cdbdc5
parent52fbe173baa4df9d14bd733f42ee6b9ceab8299b
media: uvcvideo: Allow changing noparam on the fly

Right now the parameter value is read during video_registration and
cannot be changed afterwards, despite its permissions 0644, that makes
the user believe that the value can be written.

The parameter only affects the behaviour of uvc_queue_buffer_complete(),
with only one check per buffer.

We can read the value directly from uvc_queue_buffer_complete() and
therefore allowing changing it with sysfs on the fly.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241218-uvc-deprecate-v2-3-ab814139e983@chromium.org
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/uvc/uvc_driver.c
drivers/media/usb/uvc/uvc_queue.c
drivers/media/usb/uvc/uvcvideo.h