]> www.infradead.org Git - users/jedix/linux-maple.git/commit
irqchip/irq-msi-lib: Check for NULL ops in msi_lib_irq_domain_select()
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Fri, 23 Aug 2024 10:07:12 +0000 (12:07 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 23 Aug 2024 11:55:15 +0000 (13:55 +0200)
commit880799fc7a3a127c43143935c1a8767d77c19cae
tree90a3a15ecbefb1f552fc621cf4b2d2a546aec477
parent71c8e2a7c822ee557b07d9bb49028dd269c87b2e
irqchip/irq-msi-lib: Check for NULL ops in msi_lib_irq_domain_select()

The irq_domain passed to msi_lib_irq_domain_select() may not have
msi_parent_ops set. There is a NULL pointer check for it, but unfortunately
there is a dereference of the parent ops pointer before that.

Move the NULL pointer test before the first use of that pointer.

This was found on a MacchiatoBin (Marvell Armada 8K SoC), which uses the
irq-mvebu-sei driver.

Fixes: 72e257c6f058 ("irqchip: Provide irq-msi-lib")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240823100733.1900666-1-maxime.chevallier@bootlin.com
Closes: https://lore.kernel.org/all/20240821165034.1af97bad@fedora-3.home/
drivers/irqchip/irq-msi-lib.c