]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rust: types: add Opaque::cast_from
authorAlice Ryhl <aliceryhl@google.com>
Tue, 24 Jun 2025 15:27:55 +0000 (15:27 +0000)
committerMiguel Ojeda <ojeda@kernel.org>
Tue, 15 Jul 2025 19:01:48 +0000 (21:01 +0200)
commit8802e168437840ea0b1d5ca571cd3e95681e9e2b
tree15a8ff5d18ce4eb58e07ac034ee0577634d578d4
parenta68a6bef0e75fb9e5aea1399d8538f4e3584dab1
rust: types: add Opaque::cast_from

Since commit b20fbbc08a36 ("rust: check type of `$ptr` in
`container_of!`") we have enforced that the field pointer passed to
container_of! must match the declared field. This caused mismatches when
using a pointer to bindings::x for fields of type Opaque<bindings::x>.

This situation encourages the user to simply pass field.cast() to the
container_of! macro, but this is not great because you might
accidentally pass a *mut bindings::y when the field type is
Opaque<bindings::x>, which would be wrong.

To help catch this kind of mistake, add a new Opaque::cast_from that
wraps a raw pointer in Opaque without changing the inner type. Also
update the docs to reflect this as well as some existing users.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Acked-by: Danilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20250624-opaque-from-raw-v2-1-e4da40bdc59c@google.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rust/kernel/drm/device.rs
rust/kernel/drm/gem/mod.rs
rust/kernel/lib.rs
rust/kernel/types.rs