]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: wacom: Initialize brightness of LED trigger
authorJason Gerecke <jason.gerecke@wacom.com>
Mon, 9 Dec 2024 18:40:29 +0000 (10:40 -0800)
committerJiri Kosina <jkosina@suse.com>
Tue, 10 Dec 2024 11:41:52 +0000 (12:41 +0100)
commit88006b8eca63467cf1b28fed839f4954c578eeff
tree35700fa843103c63f8a238f009737e1b50c78a16
parent8d355b56f29533e0b0db0d9a2de8bdc05ab27375
HID: wacom: Initialize brightness of LED trigger

If an LED has a default_trigger set prior to being registered with
the subsystem, that trigger will be executed with a brightness value
defined by `trigger->brightness`. Our driver was not setting this
value, which was causing problems. It would cause the selected LED
to be turned off, as well as corrupt the hlv/llv values assigned to
other LEDs (since calling `wacom_led_brightness_set` will overite
these values).

This patch sets the value of `trigger->brightness` to an appropriate
value. We use `wacom_leds_brightness_get` to transform the llv/hlv
values into a brightness that is understood by the rest of the LED
subsystem.

Fixes: 822c91e72eac ("leds: trigger: Store brightness set by led_trigger_event()")
Cc: stable@vger.kernel.org # v6.10+
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_sys.c