]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: storvsc: Set correct data length for sending SCSI command without payload
authorLong Li <longli@microsoft.com>
Thu, 23 Jan 2025 03:07:22 +0000 (19:07 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 3 Feb 2025 22:28:07 +0000 (17:28 -0500)
commit87c4b5e8a6b65189abd9ea5010ab308941f964a4
treeb233f66c5e5c189ccb21cbbb5562c676b2fbe2fc
parentf8fb2403ddebb5eea0033d90d9daae4c88749ada
scsi: storvsc: Set correct data length for sending SCSI command without payload

In StorVSC, payload->range.len is used to indicate if this SCSI command
carries payload. This data is allocated as part of the private driver data
by the upper layer and may get passed to lower driver uninitialized.

For example, the SCSI error handling mid layer may send TEST_UNIT_READY or
REQUEST_SENSE while reusing the buffer from a failed command. The private
data section may have stale data from the previous command.

If the SCSI command doesn't carry payload, the driver may use this value as
is for communicating with host, resulting in possible corruption.

Fix this by always initializing this value.

Fixes: be0cf6ca301c ("scsi: storvsc: Set the tablesize based on the information given by the host")
Cc: stable@kernel.org
Tested-by: Roman Kisel <romank@linux.microsoft.com>
Reviewed-by: Roman Kisel <romank@linux.microsoft.com>
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Long Li <longli@microsoft.com>
Link: https://lore.kernel.org/r/1737601642-7759-1-git-send-email-longli@linuxonhyperv.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/storvsc_drv.c