]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cxl: fix return value in cxlctl_validate_set_features()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 28 May 2025 08:11:41 +0000 (11:11 +0300)
committerDave Jiang <dave.jiang@intel.com>
Mon, 9 Jun 2025 16:18:15 +0000 (09:18 -0700)
commit87b42c114cdda76c8ad3002f2096699ad5146cb3
tree2bdb81518ff5342fd141e7526141e24bc709b414
parent19272b37aa4f83ca52bdf9c16d5d81bdd1354494
cxl: fix return value in cxlctl_validate_set_features()

The cxlctl_validate_set_features() function is type bool.  It's supposed
to return true for valid requests and false for invalid.  However, this
error path returns ERR_PTR(-EINVAL) which is true when it was intended to
return false.

The incorrect return will result in kernel failing to prevent a
incorrect op_size passed in from userspace to be detected.

[ dj: Add user impact to commit log ]

Fixes: f76e0bbc8bc3 ("cxl: Update prototype of function get_support_feature_info()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/aDbFPSCujpJLY1if@stanley.mountain
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/features.c