]> www.infradead.org Git - users/jedix/linux-maple.git/commit
crypto: crc32c - Fix crc32c soft dependency
authorJean Delvare <jdelvare@suse.de>
Mon, 18 Jan 2016 16:06:05 +0000 (17:06 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:44:25 +0000 (15:44 -0700)
commit87859ea9c720e63633f3e4537afc631a5c321e6a
tree2c1b431f0c9155e91afa16845f714c712cd9029c
parent9536907c0cf85049dd602f0826a0e58ef40ecede
crypto: crc32c - Fix crc32c soft dependency

Orabug: 23330759

[ Upstream commit fd7f6727102a1ccf6b4c1dfcc631f9b546526b26 ]

I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Cc: stable@vger.kernel.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 5d545a70cca8594f6120a9e3d70187920e62ce77)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
crypto/crc32c_generic.c
lib/libcrc32c.c