]> www.infradead.org Git - users/dwmw2/openconnect.git/commit
Fix buffer overflow with chunked HTTP handling (CVE-2019-16239)
authorDavid Woodhouse <dwmw2@infradead.org>
Tue, 10 Sep 2019 16:30:12 +0000 (17:30 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Wed, 11 Sep 2019 23:26:57 +0000 (00:26 +0100)
commit875f0a65ab73f4fb581ca870fd3a901bd278f8e8
tree07aeda0c225b04bd60613fa77d4d8394587104cf
parent16c1ee0433271bcaebbcd37f99b920f8177a5f75
Fix buffer overflow with chunked HTTP handling (CVE-2019-16239)

Over a decade ago, I was vocally sad about the fact that I needed to
implement HTTP client code for myself because none of the available
options at the time gave me sufficient control over the underlying
TLS connection.

This is why. A malicious HTTP server (after we have accepted its
identity certificate) can provide bogus chunk lengths for chunked
HTTP encoding and cause a heap overflow.

Reported by Lukas Kupczyk of the Advanced Research Team at CrowdStrike
Intelligence.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
http.c
www/changelog.xml